Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS layer to mediator server for cross-origin requests #275

Merged

Conversation

Hermann-Core
Copy link
Collaborator

No description provided.

@Hermann-Core Hermann-Core self-assigned this Nov 29, 2024
@Hermann-Core Hermann-Core linked an issue Nov 29, 2024 that may be closed by this pull request
Copy link
Collaborator

@Christiantyemele Christiantyemele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though we have no way of testing it 😄

@IngridPuppet
Copy link
Collaborator

Though we have no way of testing it 😄

Start the server and do fetch('http://localhost:port') in a browser console. If the request goes through then it is all fine.

src/lib.rs Outdated Show resolved Hide resolved
@Christiantyemele
Copy link
Collaborator

Though we have no way of testing it 😄

Start the server and do fetch('http://localhost:port') in a browser console. If the request goes through then it is all fine.

This will be a get request which is allowed by default we need to test a post request instead

@IngridPuppet
Copy link
Collaborator

IngridPuppet commented Dec 2, 2024

This will be a get request which is allowed by default we need to test a post request instead.

Note that a GET request is not allowed by default with regard to CORS policy. Also, if you need to test POST requests specifically, you can set the option on the fetch command. Long story short, CORS configurations are testable.

@Hermann-Core Hermann-Core merged commit 67393f1 into main Dec 3, 2024
1 check passed
@Hermann-Core Hermann-Core deleted the 274-add-cors-layer-to-the-mediator-implementation branch December 3, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CORS Layer to the mediator implementation
3 participants