New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving plugin traits to top module such as to isolate plugin implementation details #58

Merged

IngridPuppet merged 1 commit into iss-36--plugin-arch from iss-36/isolate-plugin-trait

Oct 9, 2023

Member

francis-pouatcha commented Oct 5, 2023

Isolating plugin trait from server allow us to move all plugin implementation details into the plugin module without risks of circular dependencies.


          Moving plugin traits to top module such as to isolate plugin impl.

f392b85

francis-pouatcha requested review from IngridPuppet and hugoib and removed request for IngridPuppet and hugoib

October 5, 2023 23:30

francis-pouatcha assigned francis-pouatcha and IngridPuppet and unassigned francis-pouatcha

IngridPuppet approved these changes

View reviewed changes

Collaborator

IngridPuppet left a comment

Exactly what I would've wanted too.

IngridPuppet merged commit 6334519 into iss-36--plugin-arch

IngridPuppet deleted the iss-36/isolate-plugin-trait branch

October 12, 2023 13:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet