fix realm normalization coverage #1233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a squash of the commits from multiple repositories: Original PR by sonOfRa: #818 Adaptations by thomasdarimont: https://github.com/thomasdarimont/keycloak-config-cli/tree/feature/realm-normalization Fixes #799 Co-authored-by: Simon Levermann <simon.levermann@codecentric.de> Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
AssahBismarkabah
changed the title
|
|
Hi @thomasdarimont, I’ve added additional test cases to ensure comprehensive coverage for the recent implementation. Please review them at your convenience and verify their correctness. The workflow has now been successfully completed. |
AssahBismarkabah
requested review from
st3v0rr,
francis-pouatcha and
jonasvoelcker
and removed request for
st3v0rr
|
@thomasdarimont can you rebase this onto your branch for a cleaner integration? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): This is a fix for the open ticket #1207.The change increases the coverage for the realm Normalization feature.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR