Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keycloak 23 #958

Merged
merged 13 commits into from
Dec 12, 2023
Merged

Add Keycloak 23 #958

merged 13 commits into from
Dec 12, 2023

Conversation

jonasvoelcker
Copy link
Collaborator

@jonasvoelcker jonasvoelcker commented Dec 5, 2023

What this PR does / why we need it:

This is needed to make keycloak-config-cli compatible with Keycloak 23.

Which issue this PR fixes Fixes #948 & #884

Special notes for your reviewer:

  • Updated CI to use Keycloak 23.0.1
  • Added correct spelling of "authenticatorFlow" in all import files
  • Treating default-roles-${realm} as default role even with changed description
  • Supporting new group handling, also loading sub groups manually
  • Supporting new user profile configuration (UPConfig)
  • Removed deprecated authenticator "registration-profile-action" from tests
  • Extended maven-replacer-plugin with breaking changes
  • Using util classes as replacement strategy for breaking changes (GroupUtil, SubGroupUtil)

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@jonasvoelcker jonasvoelcker force-pushed the keycloak23 branch 2 times, most recently from ef760e9 to 6a40e2e Compare December 5, 2023 09:49
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (cc36192) 95.53% compared to head (4f5563e) 95.69%.

Files Patch % Lines
.../java/de/adorsys/keycloak/config/ThreadHelper.java 16.66% 5 Missing ⚠️
...ava/de/adorsys/keycloak/config/util/GroupUtil.java 90.47% 2 Missing ⚠️
...cloak/config/repository/UserProfileRepository.java 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #958      +/-   ##
============================================
+ Coverage     95.53%   95.69%   +0.15%     
- Complexity     1324     1365      +41     
============================================
  Files            78       80       +2     
  Lines          4279     4367      +88     
  Branches        477      491      +14     
============================================
+ Hits           4088     4179      +91     
- Misses           91       95       +4     
+ Partials        100       93       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasvoelcker jonasvoelcker force-pushed the keycloak23 branch 16 times, most recently from 3f72630 to 047f6d9 Compare December 5, 2023 17:32
@jonasvoelcker jonasvoelcker force-pushed the keycloak23 branch 10 times, most recently from 9e585dd to 49e5ccc Compare December 6, 2023 09:47
@thomasdarimont
Copy link
Contributor

thomasdarimont commented Dec 7, 2023

@jonasvoelcker thanks for picking the work up from #952.

Did you take notice that Keycloak is currently reworking some changes in the group API (=reverting to old behaviour) ?
"Meaning of briefRepresentation query parameter is inverted in GroupResource.getSubGroups": keycloak/keycloak#25096
"RealmAdminResource.getGroupByPathGroup does not work with space in path parameter": keycloak/keycloak#25111

@jonasvoelcker
Copy link
Collaborator Author

Hi @thomasdarimont, does this mean that 23.0.0 and 23.0.1 Docker Images and Maven Dependencies will be overwritten so we don't need any backwards compatibility? Or do we have failure for those versions in the future, if we rely on the fixes?

@thomasdarimont
Copy link
Contributor

@jonasvoelcker IMHO those artifacts / images will not be overridden, but I assume we will get new releases, either a 23.0.x or a 24.0.x with the "corrected" (groups) behaviour.

@jonasvoelcker
Copy link
Collaborator Author

@thomasdarimont Then we should build a new profile for 23.0.0 and 23.0.1 which replaces the Util-Classes with my patched versions, which then be renamed to .java.intermediate or something like that. Therefore we also have compatibility for those two versions.

Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alwibrm
Copy link

alwibrm commented Dec 11, 2023

Any idea when this gets reviewed / merged?

@jonasvoelcker
Copy link
Collaborator Author

Hey @alwibrm,

I've already reached out to @st3v0rr, he'll take his time soon 😉

@st3v0rr
Copy link
Member

st3v0rr commented Dec 11, 2023

Hey everyone,
I finished my checks.
Thanks a lot for the contributions!
Since I had a quite exhaustive day I will merge and perform a release tomorrow morning :-)

@st3v0rr st3v0rr merged commit b413908 into adorsys:main Dec 12, 2023
13 checks passed
@jonasvoelcker jonasvoelcker deleted the keycloak23 branch December 15, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Keycloak 23.0.0
4 participants