-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Keycloak 23 #958
Add Keycloak 23 #958
Conversation
ef760e9
to
6a40e2e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
============================================
+ Coverage 95.53% 95.69% +0.15%
- Complexity 1324 1365 +41
============================================
Files 78 80 +2
Lines 4279 4367 +88
Branches 477 491 +14
============================================
+ Hits 4088 4179 +91
- Misses 91 95 +4
+ Partials 100 93 -7 ☔ View full report in Codecov by Sentry. |
3f72630
to
047f6d9
Compare
9e585dd
to
49e5ccc
Compare
2e4d5f2
to
b64bba4
Compare
b64bba4
to
313ff9c
Compare
34f6d9d
to
ddd6187
Compare
ddd6187
to
d9a4e1d
Compare
83b5f35
to
1a87c32
Compare
@jonasvoelcker thanks for picking the work up from #952. Did you take notice that Keycloak is currently reworking some changes in the group API (=reverting to old behaviour) ? |
Hi @thomasdarimont, does this mean that 23.0.0 and 23.0.1 Docker Images and Maven Dependencies will be overwritten so we don't need any backwards compatibility? Or do we have failure for those versions in the future, if we rely on the fixes? |
@jonasvoelcker IMHO those artifacts / images will not be overridden, but I assume we will get new releases, either a 23.0.x or a 24.0.x with the "corrected" (groups) behaviour. |
@thomasdarimont Then we should build a new profile for 23.0.0 and 23.0.1 which replaces the Util-Classes with my patched versions, which then be renamed to .java.intermediate or something like that. Therefore we also have compatibility for those two versions. |
3e193da
to
a98a453
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Any idea when this gets reviewed / merged? |
Hey everyone, |
What this PR does / why we need it:
This is needed to make keycloak-config-cli compatible with Keycloak 23.
Which issue this PR fixes Fixes #948 & #884
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR