Use pkg-config instead of manual -lvlc #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg-config is usually more aware of how exactly something should be linked, which may vary for different systems/environments. To make the solution more universal using pkg-config instead of manual flag `-lvlc`. Here is an example of another project which already uses this approach: https://github.com/asticode/go-astiav More specifically, see: https://github.com/asticode/go-astiav/blob/cd2a16de95f911b69a9187708abe58d2c89b4390/astiav.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pkg-config is usually more aware of how exactly something should be linked, which may vary for different systems/environments.
To make the solution more universal using pkg-config instead of manual flag
-lvlc.Here is an example of another project which already uses this approach: https://github.com/asticode/go-astiav
More specifically, see: https://github.com/asticode/go-astiav/blob/cd2a16de95f911b69a9187708abe58d2c89b4390/astiav.go
Initial motivation
I needed this change because I'm trying to link all the dependencies in one of my projects statically. I was able to hack around this for the
go-astiavvia manipulatingpkg-config, but for this project I had to add this change.