Skip to content

Commit

Permalink
Add readiness probe (cherry-pick from v1.0)
Browse files Browse the repository at this point in the history
On GKE 1.21 and earlier, I noticed HNC taking a long time (~80s) to
become Ready (for more details, see kubernetes-sigs#170). Adding a readiness probe
fixes the problem.

Tested: before this change, on GKE 1.20 and 1.21, I manually see HNC
taking a long time to start, and the e2e tests that require reinstalling
HNC fail because it the deadlines are exceeded. With this change, I can
see HNC becoming ready in ~10s on GKE 1.20 and all the e2e tests pass.
  • Loading branch information
adrianludwin committed Mar 29, 2022
1 parent 39e8ad2 commit e0a9871
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions config/manager/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ spec:
port: 8081
failureThreshold: 1
periodSeconds: 10
readinessProbe:
httpGet:
path: /readyz
port: 8081
periodSeconds: 5
startupProbe:
httpGet:
path: /readyz
Expand Down

0 comments on commit e0a9871

Please sign in to comment.