Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MDA, MWD, MWV #81

Merged
merged 4 commits into from
Sep 8, 2021
Merged

Add MDA, MWD, MWV #81

merged 4 commits into from
Sep 8, 2021

Conversation

Maescool
Copy link
Contributor

@Maescool Maescool commented Sep 4, 2021

For a project I'm receiving these sentence types.
Hope this looks okay, added tests and they work.

icholy
icholy reviewed Sep 5, 2021
View reviewed changes
mda.go Outdated Show resolved Hide resolved
adrianmo
adrianmo requested changes Sep 7, 2021
View reviewed changes
Copy link
Owner

@adrianmo adrianmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maescool thanks a lot for the contribution - you did an awesome job :)

Can you please have a look at the linter issues reported by the CI process? (I just fixed CI as it was broken so you couldn't have known before)

@adrianmo adrianmo added the kind/feature New feature label Sep 7, 2021
@Maescool
Copy link
Contributor Author

Maescool commented Sep 8, 2021

Fixed the linting, and removed the redundant empty check's

adrianmo
adrianmo approved these changes Sep 8, 2021
View reviewed changes
Copy link
Owner

@adrianmo adrianmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Waiting on the green light from @icholy :)

@adrianmo adrianmo merged commit 4de9528 into adrianmo:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmo adrianmo adrianmo approved these changes

@icholy icholy icholy approved these changes

Assignees

@Maescool Maescool

Labels
kind/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maescool @icholy @adrianmo