Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow omitting the DPT scale field #84

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Allow omitting the DPT scale field #84

merged 1 commit into from
Dec 10, 2021

Conversation

icholy
Copy link
Collaborator

@icholy icholy commented Dec 8, 2021

Fixes #83

@icholy icholy requested a review from adrianmo December 8, 2021 14:16
adrianmo
adrianmo approved these changes Dec 10, 2021
View reviewed changes
Copy link
Owner

@adrianmo adrianmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @icholy !

@adrianmo adrianmo merged commit a4c9590 into master Dec 10, 2021
@adrianmo adrianmo deleted the allow-omitting-dpt-scale branch December 10, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmo adrianmo adrianmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DPT third field depends on nmea version?
2 participants
@icholy @adrianmo