Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection expressions #256

Closed
Tracked by #9
adrianoc opened this issue Dec 8, 2023 · 0 comments
Closed
Tracked by #9

Collection expressions #256

adrianoc opened this issue Dec 8, 2023 · 0 comments
Labels
enhancement New feature or request .NET 8.0 Work that depends on .NET 8.0
Milestone
2.14

Comments

@adrianoc
Copy link
Owner

adrianoc commented Dec 8, 2023 •
edited
Loading

Documentation

Example in sharplab
@adrianoc adrianoc mentioned this issue Dec 8, 2023
Open
100 tasks
@adrianoc adrianoc added the enhancement New feature or request label Dec 8, 2023
@adrianoc adrianoc added the .NET 8.0 Work that depends on .NET 8.0 label Jan 16, 2024
@adrianoc adrianoc modified the milestones: 2.10, 2.11 Mar 22, 2024
@adrianoc adrianoc added this to the Future milestone Jun 7, 2024
@adrianoc adrianoc modified the milestones: Future, 2.14 Aug 23, 2024
adrianoc added a commit that referenced this issue Sep 25, 2024
@adrianoc
adds support and tests for initializing arrays with collection expres…
ed375d9 
…sions (#256)
adrianoc added a commit that referenced this issue Sep 25, 2024
@adrianoc
moved common array initialization code to a helper type and added Col…
a7f1c60 
…lectionExpressionProcessor type (#256)
adrianoc added a commit that referenced this issue Sep 25, 2024
@adrianoc
adds support for initializing spans with collection expressions (#256)
f01d7c7
adrianoc added a commit that referenced this issue Sep 26, 2024
@adrianoc
fixes broken code generation after refactoring of array initializatio…
6beddbf 
…n code (#256)
adrianoc added a commit that referenced this issue Sep 26, 2024
@adrianoc
adds support for initializing List<T> with collection expressions (#256)
b63e097
adrianoc added a commit that referenced this issue Sep 29, 2024
@adrianoc
fixes collection expression initialization when a implicit numeric co…
46b6e5a 
…nversion is required (#256)
adrianoc added a commit that referenced this issue Sep 29, 2024
@adrianoc
adds support for user conversions in collection expressions/array ini…
481d82e 
…tialization (#256)

also:
1. Extracts SyntaxWalkerBase.EnsureForwardedMethod() -> MethodExtensions.EnsureForwardedMethod()
2. Fixes variable names when handling constructors in some scenarios
adrianoc added a commit that referenced this issue Sep 30, 2024
@adrianoc
use test case parameterized values instead of hardcoded ones (#256)
f337d8c 
Test was using [2, 1] hardcoded collection expression instead of the parameterized values whence collection
expressions larger than 2 were not being tested.

Since this length is used to determine how the initialization is performed optimized initialization (length >= 3)
was not being tested.

Fixing this revealed a bug in the logic that selects optimized/unoptimized initialization. AFAICS optimization is only
applicable when the target of the collection expression (i.e, a variable assignment/initialization or argument passing)
is a container (array/collection/etc) of primitive types but the code was not taking this into consideration.
adrianoc added a commit that referenced this issue Sep 30, 2024
@adrianoc
adds support for boxing elements in a collection expression (#256)
16acf30
adrianoc added a commit that referenced this issue Sep 30, 2024
@adrianoc
adds support and tests for initializing arrays with collection expres…
3a4ea26 
…sions (#256)
adrianoc added a commit that referenced this issue Sep 30, 2024
@adrianoc
moved common array initialization code to a helper type and added Col…
96045c4 
…lectionExpressionProcessor type (#256)
adrianoc added a commit that referenced this issue Sep 30, 2024
@adrianoc
adds support for initializing spans with collection expressions (#256)
a1e3500
adrianoc added a commit that referenced this issue Sep 30, 2024
@adrianoc
fixes broken code generation after refactoring of array initializatio…
dd3e940 
…n code (#256)
adrianoc added a commit that referenced this issue Sep 30, 2024
@adrianoc
adds support for initializing List<T> with collection expressions (#256)
6632e35
adrianoc added a commit that referenced this issue Sep 30, 2024
@adrianoc
fixes collection expression initialization when a implicit numeric co…
6b6a5e0 
…nversion is required (#256)
adrianoc added a commit that referenced this issue Sep 30, 2024
@adrianoc
adds support for user conversions in collection expressions/array ini…
c4b2255 
…tialization (#256)

also:
1. Extracts SyntaxWalkerBase.EnsureForwardedMethod() -> MethodExtensions.EnsureForwardedMethod()
2. Fixes variable names when handling constructors in some scenarios
adrianoc added a commit that referenced this issue Sep 30, 2024
@adrianoc
use test case parameterized values instead of hardcoded ones (#256)
3c089fc 
Test was using [2, 1] hardcoded collection expression instead of the parameterized values whence collection
expressions larger than 2 were not being tested.

Since this length is used to determine how the initialization is performed optimized initialization (length >= 3)
was not being tested.

Fixing this revealed a bug in the logic that selects optimized/unoptimized initialization. AFAICS optimization is only
applicable when the target of the collection expression (i.e, a variable assignment/initialization or argument passing)
is a container (array/collection/etc) of primitive types but the code was not taking this into consideration.
adrianoc added a commit that referenced this issue Sep 30, 2024
@adrianoc
adds support for boxing elements in a collection expression (#256)
d81642e
adrianoc added a commit that referenced this issue Sep 30, 2024
@adrianoc
fix missing operand in LdObj instruction in some scenarios (#256)
a63011e 
also refactor the test code to better convey intent and avoid code duplication
@adrianoc adrianoc closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request .NET 8.0 Work that depends on .NET 8.0
Projects
None yet
Milestone
2.14
Development

No branches or pull requests
1 participant
@adrianoc