Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit all TODO and remove them #303

Closed
adrianoc opened this issue Sep 11, 2024 · 0 comments
Closed

Revisit all TODO and remove them #303

adrianoc opened this issue Sep 11, 2024 · 0 comments
Labels
fixed-in-staging
Milestone
2.16

Comments

@adrianoc
Copy link
Owner

Cases that are still relevant should have an issue created
@adrianoc adrianoc added this to the 2.15 milestone Sep 11, 2024
@adrianoc adrianoc changed the title Revisit all TODOs and either remove it Revisit all TODOs and remove it Sep 11, 2024
@adrianoc adrianoc changed the title Revisit all TODOs and remove it Revisit all TODO s and remove it Sep 11, 2024
@adrianoc adrianoc changed the title Revisit all TODO s and remove it Revisit all TODO and remove them Sep 11, 2024
@adrianoc adrianoc modified the milestones: 2.15, 2.16 Sep 29, 2024
adrianoc added a commit that referenced this issue Oct 12, 2024
@adrianoc
removed outdated TODO (#303)
16c791d 
This TODO mentions checking missing types but the code seems to be handling this scenario
in [line 107](https://github.com/adrianoc/cecilifier/blob/main/Cecilifier.Core.Tests/Framework/AssemblyDiff/AssemblyComparer.cs#L107)
adrianoc added a commit that referenced this issue Oct 12, 2024
@adrianoc
removes stale, incorrect TODO and cleans up the code (#303)
987b2a5
adrianoc added a commit that referenced this issue Oct 12, 2024
@adrianoc
use top level statements in test (#303)
5704e96
adrianoc added a commit that referenced this issue Oct 12, 2024
@adrianoc
converted TODO from code to issue #309 (#303)
f5fc600
adrianoc added a commit that referenced this issue Oct 13, 2024
@adrianoc
removes some code duplication in the area of conversion application (#…
24e115e 
…303)
adrianoc added a commit that referenced this issue Oct 13, 2024
@adrianoc
removes unclear TODO + adds a couple of tests to improve coverage (#303)
21790e9
adrianoc added a commit that referenced this issue Oct 13, 2024
@adrianoc
fixes pointer to pointer assignment emitting Stind instruction instea…
5c3430e 
…d of plain stloc/starg/stfld/etc (#303)
adrianoc added a commit that referenced this issue Oct 13, 2024
@adrianoc
addressed stackalloc with size specified through property/local varia…
bd4879a 
…ble/parameter (#303)
adrianoc added a commit that referenced this issue Oct 13, 2024
@adrianoc
replaced TODO regarding attribute handling with issue #311 (#303)
744e98c
adrianoc added a commit that referenced this issue Oct 13, 2024
@adrianoc
replaced TODO regardint tuple handling with existing issue #93 (#303)
c1a0776
adrianoc added a commit that referenced this issue Oct 13, 2024
@adrianoc
removes TODO regarding coverage of type syntaxes and adds clarifying …
932d97b 
…comment (#303)
adrianoc added a commit that referenced this issue Oct 13, 2024
@adrianoc
removes misleading TODO (#303)
251c1ce 
In this case I think introducing a constant would only make the code less readable
adrianoc added a commit that referenced this issue Oct 13, 2024
@adrianoc
fixes assignment of value types in instance methods (#303)
4e70b33
adrianoc added a commit that referenced this issue Oct 13, 2024
@adrianoc
removes outdated TODO regarding method attributes on synthetic methods (
8fee84f 
#303)

the comment mentions abstract static methods from interfaces but the method in question should only
be used while emitting synthetic methods (for instance, Add/Remove for events, get_/set_/etc for
properties, etc) and in these scenarios we probably don´t support abstract static methods.
adrianoc added a commit that referenced this issue Oct 13, 2024
@adrianoc
removes misleading TODO (#303)
7d37efa 
the comment claims that Equals(RecordType) overload should not have 'MethodAttributes.NewSlot' applied but
it seems it is not the case (the compiler does add this attribute)
adrianoc added a commit that referenced this issue Oct 13, 2024
@adrianoc
replaces TODO with issue #312 (#303)
23a6c13
adrianoc added a commit that referenced this issue Oct 18, 2024
@adrianoc
takes parameter types into account during method resolution (#303)
c8b2e21 
Also uses right parameter attributes instead of hardcoded None
adrianoc added a commit that referenced this issue Oct 18, 2024
@adrianoc
removes outdated TODO (#303)
1167133
adrianoc added a commit that referenced this issue Oct 18, 2024
@adrianoc
simplified project compression code (#303)
033a613
adrianoc added a commit that referenced this issue Oct 18, 2024
@adrianoc
improve assembly comparison code (#303)
edfd79b
adrianoc added a commit that referenced this issue Oct 18, 2024
@adrianoc
fixes field access on generic type generating invalid field reference
9934ca0 
this was found while working on #303
adrianoc added a commit that referenced this issue Oct 18, 2024
@adrianoc
includes public fields in synthetic PrintMembers() method on records (#…
f491a64 
…303)
adrianoc added a commit that referenced this issue Oct 18, 2024
@adrianoc
removes non relevant TODO (#303)
801cdad 
TODO was questioning whether it would make sense to register a variable definition; it may or may not
improve the generated code quality but the method in question is only being used to handle events
add/remove methods so it does not worth investigating it.
@adrianoc adrianoc mentioned this issue Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed-in-staging
Projects
None yet
Milestone
2.16
Development

No branches or pull requests
1 participant
@adrianoc