-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix check of node type #145
Fix check of node type #145
Conversation
Hi @Benjaminsson, thanks for your PR. |
In version 1.14.0 of enzyme-adapter-react-16 this check does not work.
c9842b8
to
a79dc3d
Compare
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 6
Lines 107 107
Branches 41 41
=====================================
Hits 107 107
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 6
Lines 107 107
Branches 41 41
=====================================
Hits 107 107
Continue to review full report at Codecov.
|
@VincentLanglet I added a test case. I don't know how much value it gives. As you can see the test coverage was already 100% and it did actually break when updating the adapter. But might be a bit more future proof now? I'm not super experienced in testing but this should do the job right? |
@Benjaminsson It's a good way for me to be sure the PR does the job. Thanks ! |
Relating to the original issue #137, I'm wondering what will be printed in the snapshot? |
Closes #137
Seems that
enzyme-adapter-react-16
was the one that broke the type checks. So this also bumps those versions to make sure the tests passes both before and after the bump.