Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for commonjs #156

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Conversation

Pipo93
Copy link
Contributor

@Pipo93 Pipo93 commented Jul 29, 2024

This addresses issue #133

adrienjoly
adrienjoly previously approved these changes Aug 3, 2024
Copy link
Owner

@adrienjoly adrienjoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM.

Can you just apply (or challenge) the suggested change before we merge, please?

Thank you for your contribution!

package.json Outdated
@@ -12,7 +14,8 @@
"test:update": "ava --update-snapshots",
"test": "ava",
"lint": "eslint .",
"semantic-release": "semantic-release"
"semantic-release": "semantic-release --dry-run",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert that change please?

Suggested change
"semantic-release": "semantic-release --dry-run",
"semantic-release": "semantic-release",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, fixed it :)

Copy link
Owner

@adrienjoly adrienjoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. merging

@adrienjoly adrienjoly merged commit e71c6bd into adrienjoly:master Aug 3, 2024
5 checks passed
Copy link

github-actions bot commented Aug 3, 2024

🎉 This PR is included in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants