Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pdf2json to v3.0.5 #145

Closed
wants to merge 1 commit into from

Conversation

madtrick
Copy link

@madtrick madtrick commented Dec 30, 2023

The previous version (v3.0.1) didn't use the verbosity argument pased
to parseBuffer, meaning that we couldn't disable the "warning" ouput.

See:

The previous version (v3.0.1) didn't use the `verbosity` argument pased
to `parseBuffer`, meaning that we couldn't disable the "warning" ouput.

See:
- `parseBuffer` in `v3.0.1` https://github.com/modesty/pdf2json/blob/v3.0.1/pdfparser.js#L134-L136
- `parseBuffer` in `v3.0.5` https://github.com/modesty/pdf2json/blob/v3.0.1/pdfparser.js#L134-L136
Copy link
Owner

@adrienjoly adrienjoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

Let's see if tests still pass in CI.

@adrienjoly
Copy link
Owner

adrienjoly commented Aug 3, 2024

No response from author + upgrade done in another PR: #156

=> closing this one.

@adrienjoly adrienjoly closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants