Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yamllint 1.8.0 no longer works with python 2.6 #55

Closed
mattclay opened this issue Jun 28, 2017 · 3 comments
Closed

yamllint 1.8.0 no longer works with python 2.6 #55

mattclay opened this issue Jun 28, 2017 · 3 comments

Comments

@mattclay
Copy link
Contributor

Now that yamllint requires pathspec as of version 1.8.0, it no longer works on python 2.6.

Here's the failure from pip install yamllint on python 2.6:

Collecting pathspec (from yamllint)
  Downloading pathspec-0.5.2.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/ly/g7l5bx455cq2c_r6z1ky8j1m0000gn/T/pip-build-y3oUIf/pathspec/setup.py", line 6, in <module>
        from pathspec import __author__, __email__, __license__, __project__, __version__
      File "pathspec/__init__.py", line 33, in <module>
        from .pathspec import PathSpec
      File "pathspec/pathspec.py", line 9, in <module>
        from . import util
      File "pathspec/util.py", line 167
        return {normalize_file(path, separators=separators): path for path in files}
                                                                    ^
    SyntaxError: invalid syntax
@adrienverge
Copy link
Owner

Hi,

Sorry to hear that. I was going to ask "is using 2.7 an option for you?" but I've just seen the problem in Ansible and I understand you cannot drop 2.6 support.

Unfortunately pathspec doesn't officially support Python 2.6: https://pypi.python.org/pypi/pathspec
I've opened cpburnz/python-pathspec#16 to try to fix that.

@mattclay
Copy link
Contributor Author

Fortunately this is only causing issues for us in CI. We don't have any Ansible modules or core functionality using yamllint. Limiting the version of yamllint that we use with python 2.6 (ansible/ansible#26186) should provide an adequate work-around.

@adrienverge
Copy link
Owner

Thanks to you and @cpburnz, yamllint supports Python 2.6 again! (version 1.8.1)

adrienverge added a commit to adrienverge/ansible that referenced this issue Jul 5, 2017
Thanks to the report by Matt Clay at [1], yamllint now supports Python
2.6. Tests were enabled on Travis for 2.6 to make sure there will be no
regressions in the future.

[1]: adrienverge/yamllint#55
mattclay pushed a commit to ansible/ansible that referenced this issue Jul 5, 2017
Thanks to the report by Matt Clay at [1], yamllint now supports Python
2.6. Tests were enabled on Travis for 2.6 to make sure there will be no
regressions in the future.

[1]: adrienverge/yamllint#55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants