build: Replace flake8 with ruff #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
adrienverge
reviewed
Jan 4, 2024
|
Perhaps I can find a ruff setting for that, ruff is more flexible than black. Let me have a look. But yes, I would recommend endorsing whatever ruff suggests and not thinking too much about it, as far as readability is not impaired. |
|
I had a look at the isort settings, I believe |
DimitriPapadopoulos
force-pushed
the
flake8_ruff
branch
from
4489978
to
2d67565
Compare
|
Can you have a look? Now ruff adds a line where there was only 1 line. Is |
DimitriPapadopoulos
force-pushed
the
flake8_ruff
branch
2 times, most recently
from
9fc579f
to
92e3f67
Compare
adrienverge
reviewed
Jan 4, 2024
DimitriPapadopoulos
force-pushed
the
flake8_ruff
branch
3 times, most recently
from
412a4fb
to
5e54699
Compare
Add isort (I) rules to the default set of ruff rules, as a replacement for flake8-import-order.
DimitriPapadopoulos
force-pushed
the
flake8_ruff
branch
from
5e54699
to
1322760
Compare
adrienverge
approved these changes
Jan 8, 2024
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/yamllint
that referenced
this pull request
Feb 1, 2024
Start with reverting parts of commit 26be794 in adrienverge#629 related to config and CI jobs.
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/yamllint
that referenced
this pull request
Feb 1, 2024
Start with reverting parts of commit 26be794 in adrienverge#629 related to config and CI jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #628.
Requires to be rebased on top of #627 to pass tests.