-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Replace flake8 with ruff #629
build: Replace flake8 with ruff #629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dimitri, I approve this 👍
I don't understand the rule "only one blank line between imports and variables", but if ruff suggests it, I guess it's better.
Perhaps I can find a ruff setting for that, ruff is more flexible than black. Let me have a look. But yes, I would recommend endorsing whatever ruff suggests and not thinking too much about it, as far as readability is not impaired. |
I had a look at the isort settings, I believe |
4489978
to
2d67565
Compare
Can you have a look? Now ruff adds a line where there was only 1 line. Is |
9fc579f
to
92e3f67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have a look? Now ruff adds a line where there was only 1 line. Is lines-after-imports = 2 really worth it?
Yeah I agree, it's not worth it.
412a4fb
to
5e54699
Compare
Add isort (I) rules to the default set of ruff rules, as a replacement for flake8-import-order.
5e54699
to
1322760
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @DimitriPapadopoulos!
Start with reverting parts of commit 26be794 in adrienverge#629 related to config and CI jobs.
Start with reverting parts of commit 26be794 in adrienverge#629 related to config and CI jobs.
Fixes #628.
Requires to be rebased on top of #627 to pass tests.