Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inefficient nbody orbit reorder #366

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Fix inefficient nbody orbit reorder #366

merged 3 commits into from
Mar 20, 2024

Conversation

adrn
Copy link
Owner

@adrn adrn commented Mar 20, 2024

Describe your changes

The original code created an unnecessarily enormous array to do the reordering.

Checklist

  • Did you add tests?
  • Did you add documentation for your changes?
  • Did you reference any relevant issues?
  • Did you add a changelog entry? (see CHANGES.rst)
  • Are the CI tests passing?
  • Is the milestone set?

@adrn adrn added this to the v1.9 milestone Mar 20, 2024
@adrn adrn merged commit 2067009 into main Mar 20, 2024
20 checks passed
@adrn adrn deleted the reorder-nbody branch March 20, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
1 participant
@adrn