Scix 467 #546
Merged
Scix 467 #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an `emitAnalytics` function to send events to a link gateway for paths starting with "/abs". Updated the middleware to call this function and avoid it for certain paths.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
========================================
- Coverage 52.0% 52.0% -0.0%
========================================
Files 339 339
Lines 37857 37857
Branches 621 619 -2
========================================
- Hits 19649 19648 -1
- Misses 18198 18199 +1
Partials 10 10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add analytics emitter in the middleware that, for now, just emits to link_gateway when a route starting with
/absis seen