Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow URL and DOI in feedback form associated articles related bibcodes #557

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

shinyichen
Copy link
Member

  • When relationship is 'other', allow URL and DOI in the associated bibcodes.
  • DOI and URL are not validated.

Screenshot 2024-11-12 at 11 08 44 AM

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.7%. Comparing base (5af91ce) to head (38224c1).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #557     +/-   ##
========================================
- Coverage    51.7%   51.7%   -0.0%     
========================================
  Files         319     319             
  Lines       37737   37737             
  Branches      632     632             
========================================
- Hits        19477   19475      -2     
- Misses      18250   18252      +2     
  Partials       10      10             

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shinyichen shinyichen merged commit 5c7a5c1 into adsabs:master Nov 19, 2024
5 checks passed
@shinyichen shinyichen deleted the SCIX-466-feedback-assoc-doi branch November 19, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants