Flamegraph helper #110
Open
Flamegraph helper #110
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install both perl helpers: - stackcollapse-phpspy.pl - vendor/flamegraph.pl These make it more convenient to generate flamegraph's when phpspy is installed systemwide Signed-off-by: BlackEagle <ike.devolder@gmail.com>
Signed-off-by: BlackEagle <ike.devolder@gmail.com>
|
Note that the choice of install paths for the perl helpers and the flamegraph wrapper make it work fine inside the repo, or when installed on a system |
|
@adsr do you think this is usefull to merge? If not I can keep the wrapper in a repo of my own. |
|
Hi @BlackIkeEagle apologies for the long delay. The script looks useful to me. I wonder if we can instead build the flamegraph format into the binary itself, removing the extra dep in the process. What do you think? |
|
You would like to avoid the perl dependency? I did not check if it would be easy to move this functionality into C |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install the perl helpers and add a simple wrapper to make it easy to generate flamegraphs