Introduce new configuration flag memory_via_R_flag to solve #4
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issue adthrasher#4 The flag allows to switch between specifying memory requirements using the -M flag and the -R "rusage[mem=]" flag when submitting the jobs via bsub. The README.md file is extended accordingly.
|
Resolved in #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
This addresses issue #4
Solution:
The flag allows to switch between specifying memory requirements using the -M flag and the -R "rusage[mem=]" flag when submitting the jobs via bsub. The README.md file is extended accordingly.
Testing:
Job submission was successfully triggered with
memory_via_R_flag = trueon our cluster which requires this setting. Settingmemory_via_R_flag = falsereproduces the error mentione in #4.Potential Extentions:
-Mwhenmemory_via_R_flagis not set.-Mand-R "rusage[mem=]". One could think of changing it from a boolean to a character specifying one flag or the other or both.