Skip to content

Commit

Permalink
openpilot isn't required for a car port PR (commaai#1183)
Browse files Browse the repository at this point in the history
* move test routes here

* check for missing

* no shebang
  • Loading branch information
adeebshihadeh authored Aug 27, 2024
1 parent f6f0674 commit 81fcc40
Show file tree
Hide file tree
Showing 4 changed files with 308 additions and 2 deletions.
2 changes: 1 addition & 1 deletion opendbc/car/gm/interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def _get_params(ret: structs.CarParams, candidate, fingerprint, car_fw, experime

# These cars have been put into dashcam only due to both a lack of users and test coverage.
# These cars likely still work fine. Once a user confirms each car works and a test route is
# added to openpilot/selfdrive/car/tests/routes.py, we can remove it from this list.
# added to opendbc/car/tests/routes.py, we can remove it from this list.
ret.dashcamOnly = candidate in {CAR.CADILLAC_ATS, CAR.HOLDEN_ASTRA, CAR.CHEVROLET_MALIBU, CAR.BUICK_REGAL} or \
(ret.networkLocation == NetworkLocation.gateway and ret.radarUnavailable)

Expand Down
2 changes: 1 addition & 1 deletion opendbc/car/hyundai/interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def _get_params(ret: structs.CarParams, candidate, fingerprint, car_fw, experime

# These cars have been put into dashcam only due to both a lack of users and test coverage.
# These cars likely still work fine. Once a user confirms each car works and a test route is
# added to openpilot/selfdrive/car/tests/routes.py, we can remove it from this list.
# added to opendbc/car/tests/routes.py, we can remove it from this list.
# FIXME: the Optima Hybrid 2017 uses a different SCC12 checksum
ret.dashcamOnly = candidate in {CAR.KIA_OPTIMA_H, }

Expand Down
Loading

0 comments on commit 81fcc40

Please sign in to comment.