Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix retroarch core running too fast under certain conditions #746

Closed

Conversation

joyrider3774
Copy link
Contributor

@joyrider3774 joyrider3774 commented Jul 31, 2024

I had an issue on my rg35xxsp with latest muos cfw test build. Where retroarch reported games running at about 120 fps with vsync on this made the games run twice as fast. i was able to fix it when testing by making the destination buffer a global and only calling video_cb once at the end of retro_run this makes sure that video_cb(destframe, 160, 160, ... is only ever called really once per frame. My guess is that it was potentially being called multiple times per frame in my case.

Now when i ran the core on my rg35xxsp it showed correctly 60 fps in the fps counter and games did not run twice as fast anymore.

It was also really noticeable while running the core with vsync off, on my rg35xxsp retroarch was reporting 1200 fps and the games were running equally fast then but with this change vsync on or off it was running always at 60 fps

I had heared on discord this may have been a known issue or was reported at least once. I do not know if this fix is valid but at least for me it fixed it

@joyrider3774
Copy link
Contributor Author

hmmm the PR is bogus what actually fixes it for me is setting audio to normal instead of callback and it just happens that i had made that change as well while testing around but it only applied after a restart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant