This repository has been archived by the owner on May 21, 2024. It is now read-only.
Only run aktualizr-repo tests with ed25519 #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1038 +/- ##
==========================================
- Coverage 82.34% 82.25% -0.09%
==========================================
Files 196 196
Lines 13858 13853 -5
==========================================
- Hits 11411 11395 -16
- Misses 2447 2458 +11
Continue to review full report at Codecov.
|
eu-siemann
approved these changes
Dec 18, 2018
pattivacek
reviewed
Dec 18, 2018
|
Nice: |
They used to be run with all key types, including big RSA. This was our longest running test, despite testing one of our less critical piece of code. Let's just use the fastest key type we have. Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
lbonn
force-pushed
the
fix/slow-repo-test
branch
from
a2fc207
to
e77dd0e
Compare
patriotyk
reviewed
Dec 18, 2018
|
@patriotyk no problem, feel free to submit enhancements in other PRs if we can have better tests with a reasonable running time. I went for the easiest way because the running time really got out of hand and was causing timeouts on Travis. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They used to be run with all key types, including big RSA.
This was our longest running test, despite testing one of our less critical piece of code. Let's just use the fastest key type we have.