-
Notifications
You must be signed in to change notification settings - Fork 60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I feel like it might be useful if Aktualizr::Pause()
didn't return until the download (if there is one in progress) is "really" paused, i.e. the image or the metadata about the image is committed to the storage. But that might be another user story.
At first glance looks great to me as well! |
Codecov Report
@@ Coverage Diff @@
## master #1075 +/- ##
==========================================
+ Coverage 75.37% 75.47% +0.09%
==========================================
Files 158 158
Lines 9262 9263 +1
==========================================
+ Hits 6981 6991 +10
+ Misses 2281 2272 -9
Continue to review full report at Codecov.
|
1b7410e
to
a58ca56
Compare
5cf8df5
to
e2f77ed
Compare
Significant changes since last review. I also removed DownloadPaused and DownloadResumed events. |
34f3632
to
d667029
Compare
d667029
to
bce9b46
Compare
Now succeeds at all time: pauses current download as well as the api queue. Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
Success or already paused or already running. Also stop sending API events as this call is synchronous. Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
bce9b46
to
766dfed
Compare
Now succeeds at all time: pauses current download as well as the api queue.
I still need to write some tests