This repository has been archived by the owner on May 21, 2024. It is now read-only.
Fix/ostree install memory leaks #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbonn
reviewed
Feb 28, 2019
| @@ -317,24 +318,24 @@ GObjectUniquePtr<OstreeDeployment> OstreeManager::getStagedDeployment() const { | |||
| } | |||
|
|
|||
| GObjectUniquePtr<OstreeSysroot> OstreeManager::LoadSysroot(const boost::filesystem::path &path) { | |||
| OstreeSysroot *sysroot = nullptr; | |||
| OstreeSysroot *sysroot_raw = nullptr; | |||
There was a problem hiding this comment.
I think you can use .reset() to update the value of a GObjectUniquePtr and forego the sysroot_raw intermediary which can potentially be misused.
There was a problem hiding this comment.
Good call. Done.
lbonn
approved these changes
Feb 28, 2019
Also rewrap a pointer from ostree_sysroot_new to try make that cleaner. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
This appears to be a false positive, and valgrind just says it is "possibly" lost anyway. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Valgrind gets really confused by this and spits out a bunch of complaints in strange places (such as ReportQueue) as well. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
pattivacek
force-pushed
the
fix/ostree-install-memory-leaks
branch
from
8f7347e
to
3bb1beb
Compare
|
Hm I've taken another look and I'm not sure the ioctl error is exactly the same. Though it's also probably a false positive. Do you have the full valgrind log? |
If I remove the suppression (or comment out the call to and |
Codecov Report
@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
- Coverage 76.07% 76.06% -0.02%
==========================================
Files 158 158
Lines 9544 9544
==========================================
- Hits 7261 7260 -1
- Misses 2283 2284 +1
Continue to review full report at Codecov.
|
|
Ok it's from here: https://github.com/ostreedev/ostree/blob/13bcc49603b54f117c44e25dc2b457b9f25d9dc0/src/libostree/ostree-sysroot-deploy.c#L1375, But no big deal anyway, this is definitely false positive. |
lbonn
approved these changes
Mar 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually fix two and suppress two others that look similar to already known issues.