This repository has been archived by the owner on May 21, 2024. It is now read-only.
Better "could not put manifest" error #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lbonn
commented
Mar 14, 2019
lbonn
commented
- stop logging it when the manifest put is inhibited by a pending install
- more detailed output when it couldn't be sent to the server
- stop logging it when the manifest put is inhibited by a pending install - more detailed output when it couldn't be sent to the server Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
Codecov Report
@@ Coverage Diff @@
## master #1137 +/- ##
=======================================
Coverage 76.17% 76.17%
=======================================
Files 164 164
Lines 9869 9869
=======================================
Hits 7518 7518
Misses 2351 2351
Continue to review full report at Codecov.
|
mike-sul
reviewed
Mar 14, 2019
| @@ -1227,6 +1226,8 @@ bool SotaUptaneClient::putManifestSimple() { | |||
| storage->clearInstallationResults(); | |||
| return true; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| At first glance it looks like the manifest assembling is redundant if there are pending updates, so I'd move line #1217 just after `if (hasPendingUpdates())` statement. |
There was a problem hiding this comment.
Good point, but I'd need to double check. I have vague memories about this function having or used to having side-effects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.