This repository has been archived by the owner on May 21, 2024. It is now read-only.
Use more recent glib suppression list #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From flatpack project. An example of these was found when running the suite under ptest. Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
Codecov Report
@@ Coverage Diff @@
## master #1179 +/- ##
=======================================
Coverage 77.97% 77.97%
=======================================
Files 170 170
Lines 10006 10006
=======================================
Hits 7802 7802
Misses 2204 2204Continue to review full report at Codecov.
|
pattivacek
reviewed
Apr 15, 2019
| @@ -23,5 +23,5 @@ cp -rf "$GITREPO_ROOT/tests/test_data/fake_root" "$TEST_INSTALL_DESTDIR" | |||
| cp -rf "$GITREPO_ROOT/src/aktualizr_repo/run/create_repo.sh" "$TEST_INSTALL_DESTDIR" | |||
| cp -rf "$GITREPO_ROOT/src/aktualizr_repo/run/serve_repo.py" "$TEST_INSTALL_DESTDIR" | |||
|
|
|||
| git -C "$GITREPO_ROOT" fetch --tags --depth=10000 || true | |||
| git -C "$GITREPO_ROOT" fetch --tags --unshallow || true | |||
There was a problem hiding this comment.
Too bad, I was worried that wouldn't work.
There was a problem hiding this comment.
Yes, @mike-sul mentioned that it wouldn't work on his docker environment: #1160 (comment). But shouldn't be a problem, since it's suffixed by || true
Not worth the trouble Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
|
In the end, I disabled shallow clones on Travis. A full clone is relatively fast compared to the docker container builds. |
pattivacek
approved these changes
Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From flatpack project.
An example of these was found when running the suite under ptest.