OTA-2487: OTA-2544: Remove the secondary discovery mechanism

[mike-sul]

As it was decided to preconfigure Primary with Secondary IPs the current discovery mechanism becomes irrelevant.

[codecov-io]

Codecov Report

Merging #1191 into master will increase coverage by 7.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1191      +/-   ##
==========================================
+ Coverage   77.22%   84.36%   +7.13%     
==========================================
  Files         173      228      +55     
  Lines       10112    17036    +6924     
==========================================
+ Hits         7809    14372    +6563     
- Misses       2303     2664     +361

Impacted Files	Coverage Δ
src/libaktualizr/config/config.cc	94.7% <ø> (-0.56%)	⬇️
.../aktualizr_secondary/aktualizr_secondary_config.cc	94.36% <ø> (+5.47%)	⬆️
...c/aktualizr_secondary/aktualizr_secondary_config.h	100% <ø> (ø)	⬆️
src/libaktualizr/config/config.h	100% <ø> (ø)	⬆️
src/libaktualizr/config/config_test.cc	98.85% <ø> (ø)
src/libaktualizr-posix/asn1/asn1_test.cc	95.13% <100%> (ø)
src/aktualizr_secondary/main.cc	80% <100%> (+9.41%)	⬆️
src/libaktualizr-posix/asn1/asn1_message.h	79.16% <100%> (+2.24%)	⬆️
src/libaktualizr-posix/asn1/asn1-cerstream.cc	35.26% <0%> (-14.46%)	⬇️
src/libaktualizr-posix/asn1/asn1-cer.cc	89.9% <0%> (-4.59%)	⬇️
... and 62 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de05467...3f3d442. Read the comment docs.

[pattivacek]

When I run grep discovery -rIin * --exclude-dir=build/ --exclude-dir=partial/ --exclude=tags --exclude=cscope.* I still see some things. Some may still be relevant, but the actions, config, and docs can almost certainly get cleansed of these references.

[mike-sul]

When I run grep discovery -rIin * --exclude-dir=build/ --exclude-dir=partial/ --exclude=tags --exclude=cscope.* I still see some things. Some may still be relevant, but the actions, config, and docs can almost certainly get cleansed of these references.

Yeah, your're right, i just removed the check-discovery and the Secondary's part of discovery, while the Primary's part and corresponding tests still there. Will update this PR.

[OYTIS]

This pull request fixes 1 alert when merging 544a07f into 2a32803 - view on LGTM.com

fixed alerts:

• 1 for FIXME comment

---

Comment posted by LGTM.com

[pattivacek]

Looks about right, but I still see a couple discovery references in src/libaktualizr-posix/asn1/messages/ipuptane_message.asn1 that I think can be removed.

[pattivacek]

Also looks like there is a really pedantic clang-format complaint.

[mike-sul]

Looks about right, but I still see a couple discovery references in src/libaktualizr-posix/asn1/messages/ipuptane_message.asn1 that I think can be removed.
Also looks like there is a really pedantic clang-format complaint.

Should be fine now.

[OYTIS]

This pull request fixes 1 alert when merging fa5c80a into de05467 - view on LGTM.com

fixed alerts:

• 1 for FIXME comment

---

Comment posted by LGTM.com

[mike-sul]

Also looks like there is a really pedantic clang-format complaint.

maybe, it's too pedantic :)

[OYTIS]

This pull request fixes 1 alert when merging 3f3d442 into de05467 - view on LGTM.com

fixed alerts:

• 1 for FIXME comment

---

Comment posted by LGTM.com