This repository has been archived by the owner on May 21, 2024. It is now read-only.
OTA-2540: Print installed and pending version on Secondary #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-sul
force-pushed
the
test/OTA-2540/ipsecondary-integration-test
branch
from
0391fa4
to
349b413
Compare
pattivacek
reviewed
May 6, 2019
src/aktualizr_info/main.cc
Outdated
| std::cout << " undetermined image version\n"; | ||
| } else { | ||
| if (installed_targets.size() > current_version) { | ||
| std::cout << " installed image version: " << installed_targets[current_version].sha256Hash() << "\n"; |
There was a problem hiding this comment.
I'd suggest saying "hash" instead of "version" for clarity -- version usually means something else in this context.
| db_storage_->clearEcuSerials(); | ||
| db_storage_->storeEcuSerials( | ||
| {{Uptane::EcuSerial(primary_ecu_serial), Uptane::HardwareIdentifier(primary_ecu_id)}, | ||
| {Uptane::EcuSerial(secondary_ecu_serial), Uptane::HardwareIdentifier(secondary_ecu_id)}}); |
There was a problem hiding this comment.
+1 for the negative test too!
…lename on secondary ECUs Signed-off-by: Mike Sul <ext-mykhaylo.sul@here.com>
mike-sul
force-pushed
the
test/OTA-2540/ipsecondary-integration-test
branch
from
349b413
to
451d2cb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print currently installed and pending image versions on secondary ECUs
Signed-off-by: Mike Sul ext-mykhaylo.sul@here.com