Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

campaign consent declined/postponed #1225

Merged
merged 2 commits into from
Jun 6, 2019

Conversation

lbonn
Copy link
Contributor

@lbonn lbonn commented Jun 4, 2019

No description provided.

Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
@lbonn lbonn force-pushed the feat/OTA-2807/consent-postponed branch from 1b425d9 to 8f449dc Compare June 4, 2019 15:47
@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #1225 into master will increase coverage by 0.09%.
The diff coverage is 81.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1225      +/-   ##
==========================================
+ Coverage   79.13%   79.22%   +0.09%     
==========================================
  Files         170      170              
  Lines       10044    10080      +36     
==========================================
+ Hits         7948     7986      +38     
+ Misses       2096     2094       -2
Impacted Files Coverage Δ
src/libaktualizr/primary/aktualizr.h 100% <ø> (ø) ⬆️
src/libaktualizr/primary/sotauptaneclient.h 100% <ø> (ø) ⬆️
src/libaktualizr/campaign/campaign.h 50% <0%> (-50%) ⬇️
src/libaktualizr/primary/reportqueue.h 23.07% <0%> (-4.2%) ⬇️
src/libaktualizr/primary/sotauptaneclient.cc 92.62% <100%> (+0.69%) ⬆️
src/libaktualizr/primary/events.h 100% <100%> (ø) ⬆️
src/libaktualizr/primary/reportqueue.cc 100% <100%> (ø) ⬆️
src/libaktualizr/primary/aktualizr.cc 97.08% <100%> (+0.34%) ⬆️
src/aktualizr_primary/main.cc 77.08% <40%> (-0.82%) ⬇️
src/libaktualizr/storage/sqlstorage_base.cc 76.19% <0%> (-2.05%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1d6de...b9d6b7e. Read the comment docs.

pattivacek
pattivacek previously approved these changes Jun 5, 2019
Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
@lbonn
Copy link
Contributor Author

lbonn commented Jun 5, 2019

Just spotted a typo actually haha (commandline help message)

@pattivacek pattivacek merged commit d23a40f into master Jun 6, 2019
@pattivacek pattivacek deleted the feat/OTA-2807/consent-postponed branch June 6, 2019 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants