This repository has been archived by the owner on May 21, 2024. It is now read-only.
Fix/ota 3059/target check sooner #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1271 +/- ##
==========================================
- Coverage 79.68% 79.64% -0.05%
==========================================
Files 173 173
Lines 10314 10315 +1
==========================================
- Hits 8219 8215 -4
- Misses 2095 2100 +5
Continue to review full report at Codecov.
|
lbonn
reviewed
Jul 29, 2019
| } | ||
| } else { |
There was a problem hiding this comment.
Minor readability: do an early exit if (updates.emtpy()) { return ... } and no else, like it's done higher up in the function. Would make it a bit easier to follow as it's the style of the rest of the logic and would avoid the if { for { if {}}} nesting
Previously the delegation walking and target matching was done in downloadImages(). It now is done in checkUpdates() so that any problems are detected as early as possible. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Previously this wouldn't've been caught until the Download step. Now it is caught during the check for updates. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
pattivacek
force-pushed
the
fix/OTA-3059/target-check-sooner
branch
from
e5eafee
to
6d57e5a
Compare
lbonn
approved these changes
Jul 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this will soon be followed up with a PR that will move
uptaneOfflineIterationto be used before downloading and installing so that metadata will get quickly re-checked before allowing either of those operations to proceed. We can optionally hold this back until that work is ready. That work will also expand the new target_mismatch_test.cc file.