This repository has been archived by the owner on May 21, 2024. It is now read-only.
Configurable reboot command #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch mainly aims to add a graceful way to reboot the system by executing a user preferred reboot command rather than calling reboot system call. The reboot command could be set in 'bootloader' section of a config file, it defaults to be '/sbin/reboot'. Signed-off-by: Mykhaylo Sul <ext-mykhaylo.sul@here.com>
Codecov Report
@@ Coverage Diff @@
## master #1274 +/- ##
==========================================
+ Coverage 79.61% 79.73% +0.12%
==========================================
Files 173 173
Lines 10315 10320 +5
==========================================
+ Hits 8212 8229 +17
+ Misses 2103 2091 -12
Continue to review full report at Codecov.
|
lbonn
approved these changes
Jul 31, 2019
pattivacek
approved these changes
Jul 31, 2019
aodukha
added a commit
that referenced
this pull request
Oct 27, 2020
Signed-off-by: Anatoliy Odukha <aodukha@gmail.com> Restore reboot_command to aktualizr config doc. It was lost during the docs transition last year. See 056b80d or #1274 for the original feature. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com> add "Find the unsigned Root and Targets metadata" page to docs Signed-off-by: Danylo Tereshchenko <ext-danylo.tereshchenko@here.com> Add a link List all of the garage-sign-related instructions on the reference page. Relates-to: OTA-5253 Signed-off-by: Halyna Dumych <ext-halyna.dumych@here.com> fixed PR review comments Signed-off-by: Anatoliy Odukha <aodukha@gmail.com>
aodukha
added a commit
that referenced
this pull request
Oct 27, 2020
Signed-off-by: Anatoliy Odukha <aodukha@gmail.com> Restore reboot_command to aktualizr config doc. It was lost during the docs transition last year. See 056b80d or #1274 for the original feature. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com> add "Find the unsigned Root and Targets metadata" page to docs Signed-off-by: Danylo Tereshchenko <ext-danylo.tereshchenko@here.com> Add a link List all of the garage-sign-related instructions on the reference page. Relates-to: OTA-5253 Signed-off-by: Halyna Dumych <ext-halyna.dumych@here.com> fixed PR review comments Signed-off-by: Anatoliy Odukha <aodukha@gmail.com>
aodukha
added a commit
that referenced
this pull request
Oct 27, 2020
Signed-off-by: Anatoliy Odukha <aodukha@gmail.com> Restore reboot_command to aktualizr config doc. It was lost during the docs transition last year. See 056b80d or #1274 for the original feature. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com> add "Find the unsigned Root and Targets metadata" page to docs Signed-off-by: Danylo Tereshchenko <ext-danylo.tereshchenko@here.com> Add a link List all of the garage-sign-related instructions on the reference page. Relates-to: OTA-5253 Signed-off-by: Halyna Dumych <ext-halyna.dumych@here.com> fixed PR review comments Signed-off-by: Anatoliy Odukha <aodukha@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replacement for #1148 to trigger the gitlab CI.
This patch mainly aims to add a graceful way to reboot the system by
executing a user preferred reboot command rather than calling reboot
system call. The reboot command could be set in 'bootloader' section of
a config file, it defaults to be '/sbin/reboot'.
Signed-off-by: Mykhaylo Sul ext-mykhaylo.sul@here.com