Create new "aktualizr-get" command #1276
Conversation
I find myself carefully crafting `wget` commands to debug issues between my device and device-gateway. This has gotten more complex now that my team is using HSMs. This adds a simple tool to work a bit like wget. Signed-off-by: Andy Doan <andy@foundries.io>
|
Feel free to reject this. Its easy enough for my team to manage out-of-tree. However, I thought you guys might find it useful also. |
src/aktualizr_get/main.cc
Outdated
| namespace bpo = boost::program_options; | ||
|
|
||
| bpo::variables_map parse_options(int argc, char *argv[]) { | ||
| bpo::options_description description("aktualizr-get command line options"); |
There was a problem hiding this comment.
Might be useful to either print something here or at least have a comment to explain what the tool is for.
src/aktualizr_get/main.cc
Outdated
| int r = EXIT_FAILURE; | ||
| try { | ||
| if (geteuid() != 0) { | ||
| LOG_WARNING << "\033[31mRunning as non-root and may not work as expected!\033[0m\n"; |
There was a problem hiding this comment.
Is that true? I don't think it applies to this tool.
Codecov Report
@@ Coverage Diff @@
## master #1276 +/- ##
=========================================
Coverage ? 78.75%
=========================================
Files ? 177
Lines ? 10417
Branches ? 0
=========================================
Hits ? 8204
Misses ? 2213
Partials ? 0
Continue to review full report at Codecov.
|
|
@patrickvacek - good points. fixed now. |
|
Looks good, but CI is still complaining about a compilation error. |
|
Looks like you fixed the compilation error, but accidentally changed the version of tuf-test-vectors, so now that is failing. If you undo that bit, it'll probably succeed. |
Signed-off-by: Andy Doan <andy@foundries.io>
|
|
|
Travis is timing out, which is annoying, but I tested it locally and it's fine. |
I find myself carefully crafting
wgetcommands to debug issuesbetween my device and device-gateway. This has gotten more complex
now that my team is using HSMs. This adds a simple tool to work
a bit like wget.
Signed-off-by: Andy Doan andy@foundries.io