This repository has been archived by the owner on May 21, 2024. It is now read-only.
Do not use the api_gateway.url. #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattivacek
force-pushed
the
fix/OTA-3490/treehub-url
branch
from
c79efa8
to
6af8b37
Compare
Codecov Report
@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
- Coverage 79.32% 79.13% -0.19%
==========================================
Files 175 175
Lines 10367 10359 -8
==========================================
- Hits 8224 8198 -26
- Misses 2143 2161 +18
Continue to review full report at Codecov.
|
Continue to use the old URLs provided by tufrepo.url and the ostree.server field of treehub.json. This reverts some of the logic of 6794911, which was unfortunately prematurly developed and merged before testing with a real implementation. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
pattivacek
force-pushed
the
fix/OTA-3490/treehub-url
branch
from
6af8b37
to
a7f7b30
Compare
pattivacek
requested review from
eu-siemann,
jochenschneider,
lbonn,
mike-sul and
Raigi
|
Manual testing with advancedtelematic/meta-updater#532 confirms that the bug is fixed. However, we need to update the creds in CI to be able to test this automatically. I think it's probably not worth holding this up for that unless that is easy to do. |
lbonn
approved these changes
Aug 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue to use the old URLs provided by treehub.url and the ostree.server field of treehub.json.
This is a partial revert of 6794911.