This repository has been archived by the owner on May 21, 2024. It is now read-only.
Remove hmi-stub and replace with references to libaktualizr-demo-app. #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add some missing items to the doxygen processing list. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
merltron
approved these changes
Aug 21, 2019
eu-siemann
reviewed
Aug 21, 2019
| @@ -128,7 +128,7 @@ When using the API, consider the following points: | |||
| * Asynchronous commands are posted to the command queue and executed in sequential order in a separate thread. | |||
| * If the execution is paused, newly issued commands accumulate in the command queue and it's up to the caller to ensure that the queue doesn't get overloaded with unnecessary duplicate commands. | |||
|
|
|||
| For an example of how to use the libaktualizr API as a primary ECU, there are two applications in the aktualizr tree that you can use as references. Aktualizr itself is in `src/aktualizr_primary`, and there is a very simple demo of using libaktualizr to interact with an HMI (for example, to get user consent) in `src/hmi_stub`. | |||
| For an example of how to use the libaktualizr API as a primary ECU, there are two applications that you can use as references. Aktualizr itself is in `src/aktualizr_primary`, and there is a very simple demo of using libaktualizr to interact with an HMI (for example, to get user consent) named https://github.com/advancedtelematic/libaktualizr-demo-app[libaktualizr-demo-app]. | |||
There was a problem hiding this comment.
I would also remove the reference to HMI here. There is basically nothing HMI related in the demo app.
There was a problem hiding this comment.
I'll do that in my other PR. I unfortunately merged this just before you posted your comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer necessary since it is now redundant with https://github.com/advancedtelematic/libaktualizr-demo-app, which is a better tool for demonstration purposes.
Also add some missing items to the doxygen processing list.