-
Notifications
You must be signed in to change notification settings - Fork 60
Conversation
This pull request introduces 1 alert when merging ba59e76 into 74fa9fd - view on LGTM.com new alerts:
Warning - Automated code review for advancedtelematic/aktualizr will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also formatting and linting issues reported on CI.
For the formatting, just run make format
to fix the issues automatically. For the lint, you'll have to look at the issues reported by make clang-tidy
and fix them.
Codecov Report
@@ Coverage Diff @@
## master #1387 +/- ##
==========================================
+ Coverage 80.43% 80.51% +0.08%
==========================================
Files 181 183 +2
Lines 10649 10911 +262
==========================================
+ Hits 8565 8785 +220
- Misses 2084 2126 +42
Continue to review full report at Codecov.
|
Signed-off-by: Eugene Smirnov <evgenii.smirnov@here.com> Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
…nStoredTarget() Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
…nStoredTarget(), pt.2 Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
…e_generator Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
3c7c665
to
f620b58
Compare
Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
15b977f
to
584b358
Compare
Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
584b358
to
59db49d
Compare
Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
void Stop_fake_http_server(FakeHttpServer *server) { | ||
// NOLINTNEXTLINE | ||
if (server != nullptr && server->valid()) { | ||
// NOLINTNEXTLINE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the linter ID here so that we know exactly what is being exempted?
…ort campaigns Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remembered we still have docs for uptane-generator at https://github.com/advancedtelematic/aktualizr/blob/master/docs/ota-client-guide/modules/ROOT/pages/uptane-generator.adoc. Probably worth adding an entry at the end.
Edit: wait, wrong PR... or did #1425 get merged into this PR?
Signed-off-by: Eugene Smirnov <evgenii.smirnov@here.com>
TEST(campaign, Campaign_to_json) { | ||
auto json = Utils::parseJSONFile(test_data_dir / "campaigns_sample.json"); | ||
|
||
auto campaigns = campaign::campaignsFromJson(json); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two tests seem redundant. Furthermore, Campaign_to_json
actually uses campaign::campaignsFromJson
. We can probably just keep one of the two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Only "Campaigns_to_json" test is remained.
Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
Signed-off-by: Mykola Chekhovoi <ext-mykola.chekhovoi@here.com>
OTA-3212 SendDeviceData()/SendManifest()/OpenStoredTarget() C APIs