Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Add version in source archives #1415

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Add version in source archives #1415

merged 2 commits into from
Oct 16, 2019

Conversation

lbonn
Copy link
Contributor

@lbonn lbonn commented Oct 15, 2019

And fail early if a version could not be determined!

And fail early if a version could not be determined!

Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine once CI is happy.

@codecov-io
Copy link

Codecov Report

Merging #1415 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1415      +/-   ##
==========================================
+ Coverage   80.38%   80.45%   +0.06%     
==========================================
  Files         181      181              
  Lines       10637    10637              
==========================================
+ Hits         8551     8558       +7     
+ Misses       2086     2079       -7
Impacted Files Coverage Δ
src/libaktualizr/primary/sotauptaneclient.cc 89.1% <0%> (-0.29%) ⬇️
src/libaktualizr/storage/sqlstorage.cc 78.04% <0%> (+0.91%) ⬆️
src/libaktualizr/uptane/directorrepository.cc 97.14% <0%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c03d246...488065e. Read the comment docs.

@lbonn lbonn merged commit a3d37b8 into master Oct 16, 2019
@lbonn lbonn deleted the rls/version-in-tarballs branch October 16, 2019 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants