Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

PackageConfig: using fake package manager for non-ostree build #1432

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

kbushgit
Copy link
Contributor

@kbushgit kbushgit commented Nov 4, 2019

Signed-off-by: Kostiantyn Bushko kbushko@intellias.com
By default, aktualizr will be built with the PackageConfig::kNone, the PackageConfig::kOstree is used only when the -DBUILD_OSTREE is defined.

This fix has no effect on meta-updater.

Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>
@lbonn
Copy link
Contributor

lbonn commented Nov 5, 2019

I'm normally not a huge fan of these ifdefs but maybe it's quite benign in this case. Is that what you had in mind @patrickvacek @eu-smirnov?

@pattivacek
Copy link
Collaborator

I think this is fine, but I'm wondering if there's a good way to test this at a low level. We generally avoid trying to put too many #ifdefs in the code, so I wonder if it's worth abstracting this somehow. But this is small and simple, so maybe it's fine as is. I encourage input from others, but in any case it's probably fine to merge as is and re-evaluate later if no good ideas emerge in the meantime.

Copy link
Contributor

@eu-siemann eu-siemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I agree about the ifdef part, but I cannot think of a better approach here.

@lbonn lbonn merged commit 9e0772a into master Nov 6, 2019
@lbonn lbonn deleted the feat/OTA-3985/default-fake-pacman branch November 6, 2019 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants