This repository has been archived by the owner on May 21, 2024. It is now read-only.
logging: Allow logger to use STDERR #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows libaktualizr to log to STDERR if LOG_STDERR is defined in the environment. A handy way this can be used is for something like aktualizr-get: LOG_STDERR=1 aktualizr-get .... This allows you to understand what is logging (stderr's fd) and what is the output (stdout's fd). Signed-off-by: Andy Doan <andy@foundries.io>
Codecov Report
@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
+ Coverage 80.28% 80.36% +0.08%
==========================================
Files 183 183
Lines 11010 11013 +3
==========================================
+ Hits 8839 8851 +12
+ Misses 2171 2162 -9
Continue to review full report at Codecov.
|
pattivacek
requested review from
pattivacek,
eu-siemann,
kbushgit,
lbonn,
mike-sul,
xcheng-here and
Zee314159
xcheng-here
approved these changes
Nov 25, 2019
pattivacek
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
FYI @doanac we are expecting to review/redo our logging at some point down the line to make it more flexible and easier to integrate in other logging systems. When that happens, this logic may have to change, but we'll be interested in your input. And for now, I see no problem with this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows libaktualizr to log to STDERR if LOG_STDERR is defined
in the environment. A handy way this can be used is for something
like aktualizr-get:
LOG_STDERR=1 aktualizr-get ....
This allows you to understand what is logging (stderr's fd) and what
is the output (stdout's fd).
Signed-off-by: Andy Doan andy@foundries.io