This repository has been archived by the owner on May 21, 2024. It is now read-only.
Fix logging issue from bug #1477 #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is subtle so I'm keeping what's really two changes as one commit: The issue is that DockerAppManger's constructor needs to create a "fake fetcher" that's not really used but required for constructing member variables and they don't have access to the global Config. Only the PackageManagerConfig. Calling the `Config` default constructor results in a call to `postUpdateValues` that then calls `logger_set_threshold` with the default logging level, INFO. This commit updates the Fetch constructor to only use the values that it needs from the globabl config: repo-server and director-server. The DockerAppMgr constructor then doesn't to create a fake global config. Signed-off-by: Andy Doan <andy@foundries.io>
Codecov Report
@@ Coverage Diff @@
## master #1478 +/- ##
=========================================
Coverage ? 80.48%
=========================================
Files ? 184
Lines ? 11092
Branches ? 0
=========================================
Hits ? 8927
Misses ? 2165
Partials ? 0
Continue to review full report at Codecov.
|
eu-siemann
approved these changes
Dec 10, 2019
lbonn
approved these changes
Dec 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is subtle so I'm keeping what's really two changes as one commit:
The issue is that DockerAppManger's constructor needs to create a
"fake fetcher" that's not really used but required for constructing
member variables and they don't have access to the global Config. Only
the PackageManagerConfig. Calling the
Configdefault constructorresults in a call to
postUpdateValuesthat then callslogger_set_thresholdwith the default logging level, INFO.This commit updates the Fetch constructor to only use the values that
it needs from the globabl config: repo-server and director-server. The
DockerAppMgr constructor then doesn't to create a fake global config.
Signed-off-by: Andy Doan andy@foundries.io