Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

More careful error checking around key generation #1499

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

lbonn
Copy link
Contributor

@lbonn lbonn commented Dec 20, 2019

As discussed in #1487

Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
@codecov-io
Copy link

Codecov Report

Merging #1499 into master will increase coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
+ Coverage   80.67%   80.78%   +0.11%     
==========================================
  Files         184      184              
  Lines       11148    11150       +2     
==========================================
+ Hits         8994     9008      +14     
+ Misses       2154     2142      -12
Impacted Files Coverage Δ
src/libaktualizr/crypto/crypto.cc 86.11% <100%> (+0.05%) ⬆️
src/uptane_generator/repo.cc 95.63% <50%> (-0.42%) ⬇️
src/libaktualizr/storage/sql_utils.h 84.5% <0%> (-1.41%) ⬇️
src/libaktualizr/storage/sqlstorage.cc 76.56% <0%> (+0.22%) ⬆️
src/libaktualizr/package_manager/ostreemanager.cc 80.14% <0%> (+1.12%) ⬆️
src/libaktualizr/storage/sqlstorage_base.cc 79.05% <0%> (+4.72%) ⬆️
src/libaktualizr/storage/sqlstorage_base.h 100% <0%> (+40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aabe543...6bd1b23. Read the comment docs.

@pattivacek pattivacek merged commit 2403384 into master Dec 23, 2019
@pattivacek pattivacek deleted the fix/keygen-checks branch December 23, 2019 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants