Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

ISSUE-1504: Virtual Secondary config #1505

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

mike-sul
Copy link
Collaborator

@mike-sul mike-sul commented Jan 3, 2020

Signed-off-by: Mykhaylo Sul myk.sul@gmail.com

…ary config

Signed-off-by: Mykhaylo Sul <myk.sul@gmail.com>
Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also make a PR against 2019.11-docs just for the example in the docs, since this bug is present in that release.

@@ -125,7 +125,7 @@ int main(int argc, char *argv[]) {
try {
Primary::initSecondaries(aktualizr, config.uptane.secondary_config_file);
} catch (const std::exception &e) {
LOG_ERROR << "Secondary initialization failed";
LOG_ERROR << "Secondary initialization failed: " << e.what();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #1505 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1505      +/-   ##
==========================================
+ Coverage   80.75%   80.79%   +0.04%     
==========================================
  Files         184      184              
  Lines       11150    11150              
==========================================
+ Hits         9004     9009       +5     
+ Misses       2146     2141       -5
Impacted Files Coverage Δ
src/aktualizr_primary/main.cc 82.4% <100%> (ø) ⬆️
src/libaktualizr/storage/sqlstorage.cc 77% <0%> (+0.44%) ⬆️
src/libaktualizr/storage/sqlstorage_base.cc 79.05% <0%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e871cc7...55a15dc. Read the comment docs.

@pattivacek pattivacek merged commit 3eeccc7 into master Jan 3, 2020
@pattivacek pattivacek deleted the fix/ISSUE-1504/virtual-config-use-bool-type branch January 3, 2020 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants