This repository has been archived by the owner on May 21, 2024. It is now read-only.
libaktualizr: Fix bug when building out-of-tree app #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been experimenting with building aktualizr-lite out-of-tree with
aktualizr as a git submodule as described in the docs. I was getting the
following error without this fix:
../aktualizr/src/libaktualizr/utilities/types.cc:62:37: error: variable 'std::istringstream jsonss' has initializer but incomplete type
62 | std::istringstream jsonss(json_str);
| ^
Signed-off-by: Andy Doan <andy@foundries.io>
Codecov Report
@@ Coverage Diff @@
## master #1572 +/- ##
==========================================
- Coverage 82.19% 82.06% -0.14%
==========================================
Files 189 189
Lines 11859 11859
==========================================
- Hits 9748 9732 -16
- Misses 2111 2127 +16
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been experimenting with building aktualizr-lite out-of-tree with
aktualizr as a git submodule as described in the docs. I was getting the
following error without this fix:
../aktualizr/src/libaktualizr/utilities/types.cc:62:37: error: variable 'std::istringstream jsonss' has initializer but incomplete type
62 | std::istringstream jsonss(json_str);
| ^
Signed-off-by: Andy Doan andy@foundries.io