This repository has been archived by the owner on May 21, 2024. It is now read-only.
Fix/abort if already registered #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't belong in the Uptane module; it only tests initialization, so now it lives next to the code that it actually tests. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Move provisioning failure logic out of the base HttpFake class since it is only used in initializer_test. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
pattivacek
requested review from
lbonn,
eu-siemann,
mike-sul,
xcheng-here and
kbushgit
Codecov Report
@@ Coverage Diff @@
## master #1579 +/- ##
==========================================
- Coverage 82.3% 82.24% -0.06%
==========================================
Files 189 189
Lines 11862 11859 -3
==========================================
- Hits 9763 9754 -9
- Misses 2099 2105 +6
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abort initialization if already ECUs are already registered.
Also includes some related test and logging improvements.