Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Added API to direct update raw_report in the installation result #1628

Merged
merged 4 commits into from
Jun 22, 2020

Conversation

kbushgit
Copy link
Contributor

@kbushgit kbushgit commented Apr 4, 2020

Signed-off-by: Kostiantyn Bushko kbushko@intellias.com

This API call should be used after installation complete and before clear of installation result clearInstallationResults in the storage.
If the device installation result does not exist in the storage the invocation of this API won't have any negative effect it just returns a negative result of the execution.

@kbushgit kbushgit force-pushed the feat/OTAPAD-200/device-install-raw-report branch from cab5de6 to 2575a2e Compare April 6, 2020 11:05
@codecov-io
Copy link

codecov-io commented Apr 6, 2020

Codecov Report

Merging #1628 into master will decrease coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
- Coverage   82.74%   82.70%   -0.04%     
==========================================
  Files         191      191              
  Lines       12087    12093       +6     
==========================================
+ Hits        10001    10002       +1     
- Misses       2086     2091       +5     
Impacted Files Coverage Δ
src/libaktualizr/primary/aktualizr.cc 95.93% <0.00%> (-1.59%) ⬇️
src/libaktualizr/primary/aktualizr.h 100.00% <ø> (ø)
src/libaktualizr/storage/invstorage.h 97.95% <ø> (ø)
src/libaktualizr/storage/sqlstorage.h 50.00% <ø> (ø)
src/libaktualizr/storage/sqlstorage.cc 80.24% <100.00%> (+0.11%) ⬆️
src/libaktualizr/storage/sqlstorage_base.h 60.00% <0.00%> (-40.00%) ⬇️
src/libaktualizr/storage/sqlstorage_base.cc 76.87% <0.00%> (-0.69%) ⬇️
src/libaktualizr/crypto/crypto.cc 83.10% <0.00%> (-0.68%) ⬇️
...libaktualizr/package_manager/packagemanagerfake.cc 91.66% <0.00%> (-0.40%) ⬇️
src/libaktualizr/uptane/tuf.cc 91.22% <0.00%> (-0.04%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6392de...71a6838. Read the comment docs.

@kbushgit kbushgit force-pushed the feat/OTAPAD-200/device-install-raw-report branch from 2575a2e to 4e45971 Compare April 6, 2020 14:03
@kbushgit kbushgit force-pushed the feat/OTAPAD-200/device-install-raw-report branch 3 times, most recently from 49bc16c to 71a6838 Compare April 30, 2020 10:46
Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the low-level tests in the Storage class, but could you also have a high-level test that uses the API call?

@kbushgit kbushgit force-pushed the feat/OTAPAD-200/device-install-raw-report branch from 71a6838 to 0d3ad0c Compare May 26, 2020 21:23
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #1628 into master will decrease coverage by 0.48%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
- Coverage   77.06%   76.58%   -0.49%     
==========================================
  Files         195      195              
  Lines       13253    13352      +99     
==========================================
+ Hits        10214    10225      +11     
- Misses       3039     3127      +88     
Impacted Files Coverage Δ
src/libaktualizr/primary/aktualizr.h 75.00% <ø> (-25.00%) ⬇️
src/libaktualizr/storage/invstorage.h 90.47% <ø> (-9.53%) ⬇️
src/libaktualizr/storage/sqlstorage.h 33.33% <ø> (-16.67%) ⬇️
src/libaktualizr/primary/aktualizr.cc 86.76% <66.66%> (-11.55%) ⬇️
src/libaktualizr/storage/sqlstorage.cc 74.02% <75.00%> (-5.29%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d089d8b...6fe3f35. Read the comment docs.

pattivacek
pattivacek previously approved these changes May 27, 2020
Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM once CI passes.

@pattivacek
Copy link
Collaborator

Can you rebase now that we have a fix for the CI problem?

@pattivacek
Copy link
Collaborator

How can we convince CI to refresh the docker image instead of pulling from the cache?

@kbushgit kbushgit force-pushed the feat/OTAPAD-200/device-install-raw-report branch from 4be905b to 28f66e7 Compare June 4, 2020 16:32
@kbushgit kbushgit force-pushed the feat/OTAPAD-200/device-install-raw-report branch from 28f66e7 to f14aec9 Compare June 18, 2020 10:25
Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>
Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>
Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>
Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>
@kbushgit kbushgit force-pushed the feat/OTAPAD-200/device-install-raw-report branch from f14aec9 to 6fe3f35 Compare June 22, 2020 09:31
@kbushgit kbushgit requested a review from pattivacek June 22, 2020 12:16
@pattivacek pattivacek merged commit 4ff75c3 into master Jun 22, 2020
@pattivacek pattivacek deleted the feat/OTAPAD-200/device-install-raw-report branch June 22, 2020 14:43
@pattivacek pattivacek changed the title Added API to direct update raw_roport in the installation result Added API to direct update raw_report in the installation result Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants