-
Notifications
You must be signed in to change notification settings - Fork 60
Added API to direct update raw_report in the installation result #1628
Conversation
cab5de6
to
2575a2e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1628 +/- ##
==========================================
- Coverage 82.74% 82.70% -0.04%
==========================================
Files 191 191
Lines 12087 12093 +6
==========================================
+ Hits 10001 10002 +1
- Misses 2086 2091 +5
Continue to review full report at Codecov.
|
2575a2e
to
4e45971
Compare
49bc16c
to
71a6838
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the low-level tests in the Storage class, but could you also have a high-level test that uses the API call?
71a6838
to
0d3ad0c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1628 +/- ##
==========================================
- Coverage 77.06% 76.58% -0.49%
==========================================
Files 195 195
Lines 13253 13352 +99
==========================================
+ Hits 10214 10225 +11
- Misses 3039 3127 +88
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM once CI passes.
Can you rebase now that we have a fix for the CI problem? |
How can we convince CI to refresh the docker image instead of pulling from the cache? |
4be905b
to
28f66e7
Compare
28f66e7
to
f14aec9
Compare
Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>
Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>
Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>
Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>
f14aec9
to
6fe3f35
Compare
Signed-off-by: Kostiantyn Bushko kbushko@intellias.com
This API call should be used after installation complete and before clear of installation result
clearInstallationResults
in the storage.If the device installation result does not exist in the storage the invocation of this API won't have any negative effect it just returns a negative result of the execution.