This repository has been archived by the owner on May 21, 2024. It is now read-only.
Drop targets when timing out because of secondaries #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the device gets into an annoying state in the UI when the secondary reconnects later. Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
lbonn
requested review from
pattivacek,
eu-siemann,
mike-sul,
xcheng-here and
kbushgit
mike-sul
approved these changes
Apr 6, 2020
pattivacek
approved these changes
Apr 6, 2020
| @@ -933,7 +933,7 @@ result::Install SotaUptaneClient::uptaneInstall(const std::vector<Uptane::Target | |||
| // stuck in an unrecoverable state here | |||
| if (!waitSecondariesReachable(updates)) { | |||
| result.dev_report = {false, data::ResultCode::Numeric::kInternalError, "Unreachable secondary"}; | |||
| return std::make_tuple(result, "Secondaries were not available", false); | |||
| return std::make_tuple(result, "Secondaries were not available", true); | |||
There was a problem hiding this comment.
I'm in favor of this, but also in favor of changing all the failures to true for drop_targets.
There was a problem hiding this comment.
I've first tried a similar approach but it broke some assumption in test_uptane:InstallFakeBad, so I opted for a minimal change for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.