This repository has been archived by the owner on May 21, 2024. It is now read-only.
dockerapp: Handle warnings from Compose gracefully #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grabbing the docker-app render STDOUT isn't safe. If that file has docker-compose *warnings*, they'll be included and then produce invalid YAML. We should write the YAML directly to disk if we are going to persist. Signed-off-by: Andy Doan <andy@foundries.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grabbing the docker-app render STDOUT isn't safe. If that file has
docker-compose warnings, they'll be included and then produce invalid
YAML. We should write the YAML directly to disk if we are going to
persist.
Signed-off-by: Andy Doan andy@foundries.io