This repository has been archived by the owner on May 21, 2024. It is now read-only.
Improve error reporting for sending metadata to Secondaries #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were writing a separate config file for each Secondary, despite that the Primary can only use one at a time. Now we create only one and append to it if it already exists. We still store the Secondary-specific files in their own subdirectories, but the exact layout is a bit different. Several tests needed adjustment to these changes, but functionally, nothing changed. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Previously, only the last Secondary to report an error would get reported. Now we handle all Secondary metadata sending failures and combine them into the device report as is done for installation. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1703 +/- ##
==========================================
- Coverage 75.44% 74.98% -0.47%
==========================================
Files 195 195
Lines 13641 13750 +109
==========================================
+ Hits 10292 10310 +18
- Misses 3349 3440 +91
Continue to review full report at Codecov.
|
kbushgit
approved these changes
Jul 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only the last Secondary to report an error would get reported. Now we handle all Secondary metadata sending failures and combine them into the device report as is done for installation.