Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Ref/libaktualizr/types #1713

Merged
merged 3 commits into from
Jul 8, 2020
Merged

Ref/libaktualizr/types #1713

merged 3 commits into from
Jul 8, 2020

Conversation

kbushgit
Copy link
Contributor

@kbushgit kbushgit commented Jul 8, 2020

No description provided.

Kostiantyn Bushko added 2 commits July 8, 2020 10:22
Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>
Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>
Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Does this make #1688 obsolete?

// std::string name;
// uint64_t len{0};
// std::string hash;
//};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

// std::string hashString(Hash::Type type) const;
//};

// std::ostream &operator<<(std::ostream &os, const Target &t);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #1713 into master will increase coverage by 3.12%.
The diff coverage is 91.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
+ Coverage   74.47%   77.59%   +3.12%     
==========================================
  Files         185      185              
  Lines       13699    13136     -563     
==========================================
- Hits        10202    10193       -9     
+ Misses       3497     2943     -554     
Impacted Files Coverage Δ
include/libaktualizr/config.h 100.00% <ø> (ø)
src/libaktualizr/crypto/crypto.cc 84.10% <ø> (ø)
src/libaktualizr/crypto/crypto.h 61.11% <ø> (-12.97%) ⬇️
src/libaktualizr/crypto/keymanager.cc 87.75% <ø> (ø)
src/libaktualizr/http/httpinterface.h 100.00% <ø> (ø)
...ktualizr/package_manager/packagemanagerinterface.h 40.00% <ø> (ø)
src/libaktualizr/primary/events.h 100.00% <ø> (ø)
src/libaktualizr/storage/invstorage.h 29.72% <ø> (-35.79%) ⬇️
src/libaktualizr/storage/storage_config.cc 100.00% <ø> (+33.33%) ⬆️
src/libaktualizr/uptane/tuf.cc 65.46% <ø> (-26.04%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d5bad...05ec550. Read the comment docs.

@kbushgit kbushgit requested a review from pattivacek July 8, 2020 11:05
Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@pattivacek pattivacek merged commit 83adb92 into master Jul 8, 2020
@pattivacek pattivacek deleted the ref/libaktualizr/types branch July 8, 2020 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants