This repository has been archived by the owner on May 21, 2024. It is now read-only.
refactoring of results and events types definitions #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 9, 2020 00:43
Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>
Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>
Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>
pattivacek
reviewed
Jul 9, 2020
src/libaktualizr/CMakeLists.txt
Outdated
| ../../include/libaktualizr/types.h | ||
| ../../include/libaktualizr/events.h | ||
| ../../include/libaktualizr/results.h | ||
| ../../include/libaktualizr/campaign.h) |
There was a problem hiding this comment.
Weird indenting change here.
There was a problem hiding this comment.
hmm, interesting, looks different in my local file
| @@ -186,7 +186,7 @@ call. This will provision with the server if required. This must be called befor | |||
| ---- | |||
| boost::signals2::connection Aktualizr::SetSignalHandler(std::function<void(shared_ptr<event::BaseEvent>)> &handler) | |||
| ---- | |||
| Returns a signal connection object, which can be disconnected if desired. The events are defined in the https://github.com/advancedtelematic/aktualizr/blob/master/src/libaktualizr/primary/events.h[`primary/events.h`] header. | |||
| Returns a signal connection object, which can be disconnected if desired. The events are defined in the https://github.com/advancedtelematic/aktualizr/blob/master/include/libaktualizr/events.h[`libaktualizr/events.h`] header. | |||
Codecov Report
@@ Coverage Diff @@
## master #1716 +/- ##
==========================================
+ Coverage 76.81% 77.55% +0.73%
==========================================
Files 185 185
Lines 13341 13204 -137
==========================================
- Hits 10248 10240 -8
+ Misses 3093 2964 -129
Continue to review full report at Codecov.
|
Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>
pattivacek
approved these changes
Jul 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kostiantyn Bushko kostiantyn.bushko@yahoo.com